Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip replica labels from series in Store Gateway #6296

Closed

Conversation

fpetkovski
Copy link
Contributor

Store Gateway is currently the only store which does not strip replica labels from stores. This causes deduplication problems for certain cases where users need to deduplicate by labels stored in TSDB.

This commit modifies store-gateway to strip replica labels when they are also stored in TSDB blocks.

This is a partial fix for #6257.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Store Gateway is currently the only store which does not strip
replica labels from stores. This causes deduplication problems for
certain cases where users need to deduplicate by labels stored in TSDB.

This commit modifies store-gateway to strip replica labels when they are
also stored in TSDB blocks.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpetkovski
Copy link
Contributor Author

fpetkovski commented Apr 24, 2023

That PR only removes replica labels from external labels, but I thought we should also strip when they are part of the series. At least this is what we do for the receiver and sidecar.

However, after my last comment, I think this would only mask the dedup problem that people are seeing in 0.31.0 and solve only a subset of issues.

@stale
Copy link

stale bot commented Jun 18, 2023

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 18, 2023
@douglascamata
Copy link
Contributor

@fpetkovski I rebased this with the tests from main and it solved the problem in the Store GW. Problem's still present in Receive and Sidecar. Do you think you can extend the fix here to these other components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants