Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: fix crash on empty regex matcher #6456

Conversation

mhoffm-aiven
Copy link
Contributor

@mhoffm-aiven mhoffm-aiven commented Jun 19, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixed crash on empty pattern in findSetMatches

Verification

Added a unittest

Signed-off-by: Michael Hoffmann <michael.hoffmann@aiven.io>
@mhoffm-aiven mhoffm-aiven force-pushed the mhoffm-fix-store-crash-on-empty-regex-matcher branch from 224ebae to 86225bc Compare June 19, 2023 06:20
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing!

Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@fpetkovski fpetkovski merged commit 88cdb28 into thanos-io:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants