Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tls_config for downstream query #6751

Closed
wants to merge 5 commits into from
Closed

added tls_config for downstream query #6751

wants to merge 5 commits into from

Conversation

Player256
Copy link
Contributor

Fixes #6674

saswatamcode
saswatamcode reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Small comment around config struct to use. Also, could you sign the commit?

pkg/queryfrontend/config.go Outdated Show resolved Hide resolved
@Player256 Player256 force-pushed the tls branch 2 times, most recently from 1ff0590 to 4241b68 Compare September 27, 2023 04:38
@Player256 Player256 marked this pull request as ready for review September 27, 2023 04:38
Kickball
Kickball reviewed Sep 28, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Player256 and others added 4 commits September 28, 2023 20:53
@Player256
added tls_config
ba54d42 
Signed-off-by: Player256 <dattucodes@gmail.com>
@Player256
changed the struct type of TLSConfig
da7c412 
Signed-off-by: Player256 <dattucodes@gmail.com>
@Player256
added the entry to changelog
b92b13c 
Signed-off-by: Player256 <dattucodes@gmail.com>
@Player256 @saswatamcode
Update cmd/thanos/query_frontend.go
e33b9ba 
Co-authored-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: space_samurai <92082372+Player256@users.noreply.github.com>
@Player256 Player256 force-pushed the tls branch 2 times, most recently from 859330c to e33b9ba Compare September 28, 2023 21:56
@Player256
removed git artefacts
fa4c88d 
Signed-off-by: Player256 <dattucodes@gmail.com>
@saswatamcode
Copy link
Member

Let's close this one in favour of #6760 @Player256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode left review comments

@Kickball Kickball Kickball left review comments

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[query-frontend] TLS configarion for downstream query backend
3 participants
@Player256 @saswatamcode @Kickball