Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the fix for npm installation in react-app-lint-fix #6829

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

lpreethvika
Copy link
Contributor

@lpreethvika lpreethvika commented Oct 20, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Error

react-app-lint-fix is failing

Run make react-app-lint-fix
>> running React app linting and fixing errors where possible
cd pkg/ui/react-app && npm run lint

> graph@0.1.0 lint /home/runner/work/thanos/thanos/pkg/ui/react-app
> eslint --fix "src/**/*.{ts,tsx}"

sh: 1: eslint: not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR! graph@0.1.0 lint: `eslint --fix "src/**/*.{ts,tsx}"`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the graph@0.1.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-10-04T10_43_30_662Z-debug.log
make: *** [Makefile:138: react-app-lint-fix] Error 1

Changes

Added the npm ci in react-app-lint-fix

Verification

Working without any npm errors

Signed-off-by: lpreethvika-samsung <l.preethvika@samsung.com>
@lpreethvika lpreethvika changed the title Added the fix for npm installation in npm lint Added the fix for npm installation in react-app-lint-fix Oct 20, 2023
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@saswatamcode saswatamcode enabled auto-merge (squash) October 25, 2023 03:30
Signed-off-by: lpreethvika-samsung <l.preethvika@samsung.com>
@saswatamcode saswatamcode merged commit 2fb2dcd into thanos-io:main Oct 25, 2023
25 of 26 checks passed
douglascamata pushed a commit to douglascamata/thanos that referenced this pull request Dec 13, 2023
Signed-off-by: lpreethvika-samsung <l.preethvika@samsung.com>
douglascamata pushed a commit to douglascamata/thanos that referenced this pull request Dec 13, 2023
Signed-off-by: lpreethvika-samsung <l.preethvika@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants