Cut 0.33.0-rc.0 #6841
Merged
Cut 0.33.0-rc.0 #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-release-0.33
branch
from
fb08caa to
b311715
Compare
MichaHoffmann
force-pushed
the
mhoffm-release-0.33
branch
from
b311715 to
664f5a5
Compare
metalmatze
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
I'd say to make these changes directly to main but they'll eventually merge back, so it should be fine.
There was a problem hiding this comment.
+1 to have this change in main, but doesn't block this pr
fpetkovski
approved these changes
Oct 24, 2023
yeya24
approved these changes
Oct 24, 2023
squat
reviewed
Oct 24, 2023
| @@ -23,7 +23,7 @@ Release shepherd responsibilities: | |||
|
|
|||
| | Release | Time of first RC | Shepherd (GitHub handle) | | |||
| |---------|----------------------|-------------------------------| | |||
| | v0.33.0 | (planned) 2023.10.03 | TBD | | |||
There was a problem hiding this comment.
this change is causing the docs check to fail
squat
requested changes
Oct 24, 2023
saswatamcode
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
LGTM! Just need to fix the docs check.
I think it might be a bit more convenient to prep main first for v0.33 via a PR like: #6617
Otherwise, you might get a bunch of merge conflicts
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-release-0.33
branch
from
664f5a5 to
98875c7
Compare
saswatamcode
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.