Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: Added a new flag for max-source-resolution #7080

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rule: Added a new flag for max-source-resolution #7080

wants to merge 3 commits into from

Conversation

kartikaysaxena
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #7077
Added a new flag for max-source-resolution

@kartikaysaxena
added a new flag for max-source-resolution
3b0adc5 
Signed-off-by: Kartikay <120778728+kartikaysaxena@users.noreply.github.com>
@kartikaysaxena
lint
f8d5a7a 
Signed-off-by: Kartikay <120778728+kartikaysaxena@users.noreply.github.com>
yeya24
yeya24 previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 19, 2024
@kartikaysaxena
added changelog
594298a 
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 19, 2024
@kartikaysaxena
Copy link
Contributor Author

Hey @yeya24 I have added the changelog, can you please take a look?

yeya24
yeya24 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have another pair of eyes to review this

@kartikaysaxena
Copy link
Contributor Author

cc @MichaHoffmann @bwplotka @GiedriusS

@KingRebo38
Copy link

@yeya24 will this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruler: Implement flag for max-source-resolution in the rule query
3 participants
@kartikaysaxena @KingRebo38 @yeya24