Store: batch tsdb infos #7308
Merged
Store: batch tsdb infos #7308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-batch-tsdb-infos-in-bucket-store
branch
3 times, most recently
from
89eb1a7
to
745c3fc
Compare
Batch TSDB Infos for bucket store for blocks with overlapping ranges. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-batch-tsdb-infos-in-bucket-store
branch
from
745c3fc
to
fa8f2a6
Compare
fpetkovski
reviewed
Apr 26, 2024
| cur = info | ||
| continue | ||
| } | ||
| cur.MaxTime = info.MaxTime |
There was a problem hiding this comment.
Won't this modify existing objects in place?
There was a problem hiding this comment.
yeah, but that should not be a problem because they are not shared and are accounted for, we just send the modified infos
fpetkovski
approved these changes
Apr 26, 2024
Nashluffy
pushed a commit
to Nashluffy/thanos
that referenced
this pull request
May 14, 2024
Batch TSDB Infos for bucket store for blocks with overlapping ranges. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de> Signed-off-by: mluffman <nashluffman@gmail.com>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Jun 1, 2024
Batch TSDB Infos for bucket store for blocks with overlapping ranges. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Jun 4, 2024
Batch TSDB Infos for bucket store for blocks with overlapping ranges. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of returning a TSDB Info for every block we batch them if their ranges are continous.
Verification
Added a unittest.
Should address #7213