Query: fix exemplar proxying for receivers with multiple tenants #7326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-stanaka
force-pushed
the
fix/exemplars-store-multitsdb
branch
from
4218d63
to
5ae2d70
Compare
pedro-stanaka
changed the title
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
When using the exemplars proxy to search for exemplars on receivers, if one receiver had tenants that did not match the selector on the external label it would get skipped completely even if it had a tenant that actually matched Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
pedro-stanaka
force-pushed
the
fix/exemplars-store-multitsdb
branch
from
e25690e
to
20a608a
Compare
fpetkovski
reviewed
May 3, 2024
fpetkovski
reviewed
May 3, 2024
pkg/exemplars/proxy.go
Outdated
| for m := range matcherSet { | ||
| labelMatchers = append(labelMatchers, m) | ||
| for _, m := range matcherSet { | ||
| if isExternalLabel(m.Name, extLbls) { |
There was a problem hiding this comment.
I wonder if we should propagate labels matchers here, but check them in tsdb.go. Otherwise all tenants in a receiver will match whenever a single tenant matches.
There was a problem hiding this comment.
I guess it will fail when proxying via sidecar? Because we are also passing the query as is there. We could leave this as a follow up and maintain behavior for now.
I think the best approach is to cover on all places, but would require ppl upgrading all components if they are running on distributed mode. Otherwise exemplars queries will not match anything.
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
fpetkovski
approved these changes
May 3, 2024
MichaHoffmann
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification