Propagate request ID through gRPC context #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request ID only gets propagated through HTTP calls and is not available in gRPC servers. This commit adds intereceptors to grpc servers and clients to make sure request ID propagation happens. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
yeya24
approved these changes
May 15, 2024
I need to double check how we can get this to the logger now. I think we use message tags right now (which works only locally), but we will have the request ID in the context and we can get it from there. |
|
Yeah I think the logger needs to be changed. Now the logger is the one in the bucket store instance and it doesn't take context into account so request ID cannot be propagated. It would be nice to make the logger customizable using context so that Cortex can be benefited as well. As Cortex uses a different request ID format from Thanos so we need it to be a hook |
|
Let's merge this and we can go ahead and implement the logger hook |
2 tasks
hczhu-db
pushed a commit
to databricks/thanos
that referenced
this pull request
Aug 22, 2024
* Propagate request ID through gRPC context The request ID only gets propagated through HTTP calls and is not available in gRPC servers. This commit adds intereceptors to grpc servers and clients to make sure request ID propagation happens. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add license Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
hczhu-db
pushed a commit
to databricks/thanos
that referenced
this pull request
Aug 22, 2024
* Propagate request ID through gRPC context The request ID only gets propagated through HTTP calls and is not available in gRPC servers. This commit adds intereceptors to grpc servers and clients to make sure request ID propagation happens. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add license Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request ID only gets propagated through HTTP calls and is not available in gRPC servers.
This commit adds intereceptors to grpc servers and clients to make sure request ID propagation happens.
Changes
Verification