Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix debug log on exit #7614

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

simonpasquier
Copy link
Contributor

@simonpasquier simonpasquier commented Aug 8, 2024

Before the change:

... msg="maxprocs: No GOMAXPROCS change to reset%!(EXTRA []interface {}=[])

After this change:

... msg="maxprocs: No GOMAXPROCS change to reset"
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Before the change:

```
... msg="maxprocs: No GOMAXPROCS change to reset%!(EXTRA []interface {}=[])
```

After this change:

```
... msg="maxprocs: No GOMAXPROCS change to reset"
```

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier changed the title fix: fix debug log on exit *: fix debug log on exit Aug 8, 2024
@simonpasquier
Copy link
Contributor Author

cc @saswatamcode

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saswatamcode saswatamcode enabled auto-merge (squash) August 8, 2024 16:00
@saswatamcode saswatamcode merged commit dcadaae into thanos-io:main Aug 9, 2024
19 of 20 checks passed
simonpasquier added a commit to simonpasquier/thanos that referenced this pull request Aug 9, 2024
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
saswatamcode pushed a commit that referenced this pull request Aug 10, 2024
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
jnyi pushed a commit to jnyi/thanos that referenced this pull request Oct 17, 2024
Before the change:

```
... msg="maxprocs: No GOMAXPROCS change to reset%!(EXTRA []interface {}=[])
```

After this change:

```
... msg="maxprocs: No GOMAXPROCS change to reset"
```

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants