fix(ui): add null check to find overlapping blocks logic #7644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pureiboi
force-pushed
the
fix/block-overlapping-ui
branch
2 times, most recently
from
8c5da82 to
4eb31aa
Compare
|
e2e GO test 8,5 and 8,7 were facing connection refused doubt this is related to the changes i committed react / React UI test on Node 14 test, didn't seems to be related to commit. any advice on this? |
GiedriusS
reviewed
Aug 16, 2024
| @@ -156,7 +156,11 @@ export const getFilteredBlockPools = ( | |||
| const poolArrayIndex = blockPools[key]; | |||
| const poolArray = poolArrayIndex[Object.keys(poolArrayIndex)[0]]; | |||
| for (let i = 0; i < filteredBlocks.length; i++) { | |||
| if (JSON.stringify(filteredBlocks[i].thanos.labels) === JSON.stringify(poolArray[0][0].thanos.labels)) { | |||
| if ( | |||
There was a problem hiding this comment.
Would it be possible to add a unit test for this? We typically add tests together with these fixes to avoid accidental regressions in the future.
There was a problem hiding this comment.
the newly added test data should cover the unit test for regression
If I were to remove the if condition, the error would flag up.
having the condition implemented, unit is able to pass
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
pureiboi
force-pushed
the
fix/block-overlapping-ui
branch
from
acf18d4 to
eb9469f
Compare
|
fixed failure on react / React UI test |
GiedriusS
approved these changes
Aug 27, 2024
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
…7644) Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add null check to find overlapping blocks logic to solve #5359.
Verification
tested locally, compare result with both unchecked vs checked