store: Implement metadata API limit in stores #7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
implement_limit_in_stores
branch
from
e061ad0
to
76a3db2
Compare
harry671003
force-pushed
the
implement_limit_in_stores
branch
2 times, most recently
from
fadedb9
to
d31ed17
Compare
harry671003
changed the title
harry671003
force-pushed
the
implement_limit_in_stores
branch
2 times, most recently
from
56f8311
to
d4cea97
Compare
harry671003
force-pushed
the
implement_limit_in_stores
branch
from
d4cea97
to
341d5d3
Compare
yeya24
reviewed
Aug 27, 2024
| @@ -1945,8 +1958,13 @@ func (s *BucketStore) LabelNames(ctx context.Context, req *storepb.LabelNamesReq | |||
| return nil, status.Error(codes.Unknown, errors.Wrap(err, "marshal label names response hints").Error()) | |||
| } | |||
|
|
|||
| names := strutil.MergeSlices(sets...) | |||
There was a problem hiding this comment.
Do we think it is worth it to pass limit into strutil.MergeSlices and truncate there?
func MergeSlices(a ...[]string) []string {
if len(a) == 0 {
return nil
}
if len(a) == 1 {
return a[0]
}
l := len(a) / 2
return mergeTwoStringSlices(MergeSlices(a[:l]...), MergeSlices(a[l:]...))
}
For example, if the limit is < len(a) / 2, we can skip merging the second half of slice.
There was a problem hiding this comment.
But this is not a blocker, we can do it in further prs
There was a problem hiding this comment.
Thanks Ben. I can look into it. Since this PR has gotten too big, I prefer to do in a follow up PR. :)
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
force-pushed
the
implement_limit_in_stores
branch
from
341d5d3
to
44b5b9c
Compare
|
Can we add acceptance tests in a followup PR? Just to make sure that all store implementations support this |
yeya24
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thanks! This looks good. Agree with @MichaHoffmann that we need to update acceptance test in next pr.
3 tasks
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
* Store: Implement metadata API limit in stores Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> * Apply seriesLimit in nextBatch Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> --------- Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is part of #7575 and implements the metadata API limit in stores.
Verification