query: queryable is not respecting limits #7679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann/queryable-is-not-respecting-limits
branch
from
b9fd921
to
69389d0
Compare
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffmann/queryable-is-not-respecting-limits
branch
from
69389d0
to
8e8118c
Compare
GiedriusS
approved these changes
Sep 2, 2024
didukh86
pushed a commit
to didukh86/thanos
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We were not using the limited store in the queryable used for implementing Select for the query engine. As a result query limits are never applied inside of the root querier even if configured. They would only be respected if the querier operated as a series proxy.
Verification
Tested it locally; Limits were applied in a build from this PR but not in a build from main.