*: get rid of store info api #7704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann-get-rid-of-store-info-api
branch
3 times, most recently
from
097ba70 to
a44a079
Compare
MichaHoffmann
force-pushed
the
mhoffmann-get-rid-of-store-info-api
branch
from
a44a079 to
9796dfc
Compare
MichaHoffmann
force-pushed
the
mhoffmann-get-rid-of-store-info-api
branch
from
9796dfc to
c5f190a
Compare
We support the Info gRPC api for 3 years now. We used to use Store API Info as fallback if we encounter an endpoint that does not implement Info gRPC but that should not happen now anymore. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffmann-get-rid-of-store-info-api
branch
from
c5f190a to
a009dcf
Compare
fpetkovski
approved these changes
Sep 6, 2024
yeya24
approved these changes
Sep 6, 2024
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
We support the Info gRPC api for 3 years now. We used to use Store API Info as fallback if we encounter an endpoint that does not implement Info gRPC but that should not happen now anymore. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
fpetkovski
pushed a commit
to fpetkovski/thanos
that referenced
this pull request
Oct 17, 2024
We support the Info gRPC api for 3 years now. We used to use Store API Info as fallback if we encounter an endpoint that does not implement Info gRPC but that should not happen now anymore. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
fpetkovski
added a commit
to fpetkovski/thanos
that referenced
this pull request
Oct 17, 2024
*: get rid of store info api (thanos-io#7704)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support the Info gRPC api for 3 years now. We used to use Store API Info as fallback if we encounter an endpoint that does not implement Info gRPC but that should not happen now anymore. This breaks compatibility with pre 0.22 version endpoints - but I would guess that they dont work well with current queriers anyway.
Changes
Removed Info Store gRPC call.
Verification
Querier still starts and discovers a sidecar. Also the existing test suite.