Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dedup proxy in multi-tsdb #7793

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

fpetkovski
Copy link
Contributor

The receiver manages independent TSDBs which do not have duplicated series. For this reason it should be safe to disable deduplication of chunks and reduce CPU usage for this path.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

The receiver manages independent TSDBs which do not have duplicated series.
For this reason it should be safe to disable deduplication of chunks and
reduce CPU usage for this path.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@GiedriusS GiedriusS merged commit f8af674 into thanos-io:main Oct 1, 2024
21 of 22 checks passed
jnyi pushed a commit to jnyi/thanos that referenced this pull request Oct 17, 2024
The receiver manages independent TSDBs which do not have duplicated series.
For this reason it should be safe to disable deduplication of chunks and
reduce CPU usage for this path.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants