Cut down test times #7861
Merged
Cut down test times #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
cut_down_test_times
branch
from
2011fe0 to
4ab3359
Compare
fpetkovski
previously approved these changes
Oct 28, 2024
GiedriusS
force-pushed
the
cut_down_test_times
branch
9 times, most recently
from
184a56e to
38a4be8
Compare
Refactor so that leak detection is happening in TestMain; Use t.Parallel() everywhere; Reduce series/samples count in some tests that reuse the same functions we use for benchmarking i.e. leave higher loads for benchmarks Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
cut_down_test_times
branch
from
38a4be8 to
d51bd15
Compare
|
@GiedriusS I see that you migrated unit tests to github. Can we make the CircleCI status not required for PRs? |
saswatamcode
approved these changes
Oct 29, 2024
|
Yeah, will do that. I got fed up with CircleCI and that's why I moved our tests to there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor so that leak detection is happening in TestMain; Use t.Parallel() everywhere;
Reduce series/samples count in some tests that reuse the same functions we use for benchmarking i.e. leave higher loads for benchmarks