Fix ExternalLabels() for Prometheus v3.0 #7893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus v3.0.0-rc.0 introduces a new scrape protocol (`PrometheusText1.0.0`) which is present by default in the global configuration. It breaks the Thanos sidecar when it wants to retrieve the external labels. This change replaces the use of the Prometheus `GlobalConfig` struct by a minimal struct which unmarshals only the `external_labels` key. See also prometheus-operator/prometheus-operator#7078 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
fix-external-labels-with-prom3
branch
from
dcb1c2e
to
cdbbf1a
Compare
1 task
saswatamcode
approved these changes
Nov 8, 2024
What we've done for Prometheus operator (and this is how we found out the issue) is to configure a periodic workflow running all our e2e tests with the latest v3.0.0 release (currently rc.0). It gives an early signal on potentially breaking changes. |
|
Yup, I think we might need similar! In any case, merging this fix |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prometheus v3.0.0-rc.0 introduces a new scrape protocol (
PrometheusText1.0.0) which is present by default in the global configuration. It breaks the Thanos sidecar when it wants to retrieve the external labels.This change replaces the use of the Prometheus
GlobalConfigstruct by a minimal struct which unmarshals only theexternal_labelskey.See also prometheus-operator/prometheus-operator#7078
Verification
Unit test added.