Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: add custom_config field #7934

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milinddethe15
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

New custom_config field to set hedging config in bucket.yml

Verification

Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused about this PR.

https://github.com/thanos-io/thanos/pull/7860/files#diff-3750e2beab2a47b781819ff1d3ecf9eeea52b3a6a10612de00cd13aa94f318ecR585
we already documented how to configure hedged reuqest in the previous PR. You meant the configuration was actually not working in that PR, and this PR fixes it?

@milinddethe15
Copy link
Contributor Author

It just improves the docs and structure for yaml.

  • config can be set as following:
custom_config:
  hedging_config:
    enabled: false
    up_to: 0
    quantile: 0
  • Now it is included in the example bucket.yaml in the docs.

custom_config can be extra field, which can be removed but adding hedging_config in the example bucket.yaml in docs was my main motive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants