Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Remove redundant redis config #7942

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Documentation: Remove redundant redis config #7942

merged 1 commit into from
Nov 28, 2024

Conversation

bluesky6529
Copy link
Contributor

According to #6520, pool_size, min_idle_conns, idle_timeout, and max_conn_age should be removed."

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@bluesky6529
remove redundant redis config
5af2a01 
Signed-off-by: Helen Tseng <bluesky6529@gmail.com>
pedro-stanaka
pedro-stanaka approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@pedro-stanaka pedro-stanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@saswatamcode saswatamcode merged commit e133849 into thanos-io:main Nov 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

@pedro-stanaka pedro-stanaka pedro-stanaka approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluesky6529 @pedro-stanaka @saswatamcode