Capnp: Use segment from existing message #7945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
MichaHoffmann
previously approved these changes
Nov 28, 2024
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
|
Can confirm this solves issue #7944 in our DEV environment 🚀 |
pedro-stanaka
approved these changes
Nov 28, 2024
saswatamcode
approved these changes
Nov 28, 2024
|
Yes, we should cut 0.37.1 👍 |
@fpetkovski Really excited about getting capnproto, is there anything I can do to initiate a new patch release? We'de prefer to run official releases in our production environment 😄 Also would be amazing if #7674 can be included in that release |
|
Yup, will try to initiate it today |
saswatamcode
pushed a commit
to saswatamcode/thanos
that referenced
this pull request
Dec 3, 2024
* Capnp: Use segment from existing message Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Downgrade capnproto Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
|
Cutting here #7952 |
saswatamcode
pushed a commit
to saswatamcode/thanos
that referenced
this pull request
Dec 3, 2024
* Capnp: Use segment from existing message Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Downgrade capnproto Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
saswatamcode
added a commit
that referenced
this pull request
Dec 4, 2024
* Merge pull request #7674 from didukh86/query_frontend_tls_redis_fix Query-frontend: Fix connection to Redis cluster with TLS. Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Capnp: Use segment from existing message (#7945) * Capnp: Use segment from existing message Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Downgrade capnproto Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * [Receive] Fix race condition when adding multiple new tenants at once (#7941) * [Receive] fix race condition Signed-off-by: Yi Jin <yi.jin@databricks.com> * add a change log Signed-off-by: Yi Jin <yi.jin@databricks.com> * memorize tsdb local clients without race condition Signed-off-by: Yi Jin <yi.jin@databricks.com> * fix data race in testing with some concurrent safe helper functions Signed-off-by: Yi Jin <yi.jin@databricks.com> * address comments Signed-off-by: Yi Jin <yi.jin@databricks.com> --------- Signed-off-by: Yi Jin <yi.jin@databricks.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Cut patch release v0.37.1 Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Update promql-engine for subquery fix (#7953) Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Sidecar: Ensure limit param is positive for compatibility with older Prometheus (#7954) Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Update changelog Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix changelog Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> --------- Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Yi Jin <yi.jin@databricks.com> Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: Yi Jin <96499497+jnyi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an occasional issue with the latest capnproto version where segments are not properly attached to the message arena.
Downgrading the version solves the problem.
Changes
Verification