store: Added missing matcher logic for negative matchers. #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
commented
Feb 13, 2019
pkg/store/bucket_e2e_test.go
Outdated
| @@ -134,10 +134,44 @@ func testBucketStore_e2e(t testing.TB, ctx context.Context, s *storeSuite) { | |||
| req *storepb.SeriesRequest | |||
| expected [][]storepb.Label | |||
| }{ | |||
| //{ | |||
There was a problem hiding this comment.
debug in progress - something does not work properly with allWithout function.
bwplotka
force-pushed
the
matchers-fix
branch
from
6c5ec34
to
931b5bc
Compare
bwplotka
changed the title
bwplotka
force-pushed
the
matchers-fix
branch
from
931b5bc
to
0f2637f
Compare
domgreen
approved these changes
Feb 15, 2019
| @@ -1178,32 +1178,33 @@ func (r *bucketIndexReader) lookupSymbol(o uint32) (string, error) { | |||
| // chunk where the series contains the matching label-value pair for a given block of data. Postings can be fetched by | |||
| // single label name=value. | |||
| func (r *bucketIndexReader) ExpandedPostings(ms []labels.Matcher) ([]uint64, error) { | |||
There was a problem hiding this comment.
nit - Fix comment above Postings > ExtendedPostings
Needed to refactor logic to add "posting groups". Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
matchers-fix
branch
from
0f2637f
to
18a3a88
Compare
bwplotka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to refactor logic to add "posting groups".
Some debug in progress, but overall showing the direction (:
Fixes: #834
Signed-off-by: Bartek Plotka bwplotka@gmail.com