Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact: skip compaction for blocks with no samples #904

Merged
merged 9 commits into from
Mar 12, 2019
Merged

Compact: skip compaction for blocks with no samples #904

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c632532
skip compaction for blocks with no samples
Mar 11, 2019
79b98ed
update to actually delete the empty input blocks, and to correctly ha…
Mar 11, 2019
eb2b5df
warn on error deleting empty block
Mar 11, 2019
05bd7fd
use ULID instead of error for emptyBlockSentinel
Mar 11, 2019
7453588
don't use a global variable
Mar 11, 2019
b0ac1b7
full stop at end of comment
Mar 11, 2019
385a991
use boolean to indicate whether there is more compaction work
Mar 12, 2019
a731d85
rename variables
Mar 12, 2019
aedea91
fix test
Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/compact/compact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,11 @@ func (cg *Group) compact(ctx context.Context, dir string, comp tsdb.Compactor) (
if err != nil {
return compID, halt(errors.Wrapf(err, "compact blocks %v", plan))
}
if compID == (ulid.ULID{}) {
// Prometheus compactor found that the compacted block would have no samples.
level.Info(cg.logger).Log("msg", "skipping compaction as compacted block would have no samples", "blocks", fmt.Sprintf("%v", plan))
return compID, nil
}
level.Debug(cg.logger).Log("msg", "compacted blocks",
"blocks", fmt.Sprintf("%v", plan), "duration", time.Since(begin))

Expand Down