Update Discoverer.js #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning true on the error parameter for non-Wemo devices acts as an error for the whole async.map(). If this is returned prior to getting to the Wemo it will fail to detect it.
Missing change in reference to new module.
…hange feedback. Changed: Changed the 'on' and 'off' methods to 'switchOn' and 'switchOff' so as not to interfere with the EventEmitter's on method.
…sometimes on property mode. Now only using mode.
…r rather than using a callback. Added: Ability to detect IP device IP changes via discovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning true on the error parameter for non-Wemo devices acts as an error for the whole async.map(). If this is returned prior to getting to the Wemo it will fail to detect it.