Implement full signOut flow #8
Conversation
- Refactored Callback component to be generic and call whatever redirect function it was given. - Added a SignoutCallback component, to be rendered at the appropriate signout url. - Call signoutRedirect in the signOut method.
| <Callback | ||
| onSuccess={props.onSuccess} | ||
| onError={props.onError} | ||
| redirectCallback={props.userManager.signinRedirectCallback} |
There was a problem hiding this comment.
Need to props.userManager.signinRedirectCallback.bind(props.userManager)
| <Callback | ||
| onSuccess={props.onSuccess} | ||
| onError={props.onError} | ||
| redirectCallback={props.userManager.signoutRedirectCallback} |
|
@thchia, is there any reason why you closed this PR? Full sign out changes made to |
|
Hey, you can look through #7 for an explanation, but basically I determined that the functionality that I was trying to add was not compatible with all Identity Providers. Since this is supposed to be IdP agnostic I closed the PR. However there are 2 ways for you to handle this:
|
For #7
This will be released in the next 0.x release, since the implementation of
signOuthas changed.