Updates for Makie 0.22 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Gentle ping. |
|
Hi @kbarros - thanks a bunch for this and thanks also for the ping; I've been down with the flu several days this week, hence my lack of a reply. This is great (!): thanks for tracing this all the way to the Makie repo and for finding the fix - much appreciated. |
This was referenced Jan 24, 2025
|
Thanks for merging. And sorry to hear about the flu. If you haven't done it yet, would you mind tagging a release? This way the Brillouin dependency won't conflict with the Makie update. |
|
Thanks for the reminder: done. Should be registered in 5-10 min. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables Makie 0.22 in the Project.toml compat section, and removes the "autolimitmargin" options to both
AxisandAxis3. The latter resolves artifacts that were observed in the Makie bump, in both 2D and 3D. Cf. MakieOrg/Makie.jl#4741 (comment).