Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Javascript] Fyrejet update to 3.0 #4017

Merged
merged 5 commits into from
Mar 8, 2021
Merged

[Javascript] Fyrejet update to 3.0 #4017

merged 5 commits into from
Mar 8, 2021

Conversation

schamberg97
Copy link
Contributor

New fyrejet major version.

One of the modes in the framework is removed. uWebSockets version is still provided, hopefully it is not going to create problems this time around.

@schamberg97 schamberg97 requested a review from waghanza as a code owner March 1, 2021 17:01
@waghanza
Copy link
Collaborator

waghanza commented Mar 1, 2021

Awesome.

You can also test the new features #3958, I mean this feature allow one framework to be test with multiple runtimes (node / deno if provided / uWebSocket / turbo ...)

@waghanza
Copy link
Collaborator

waghanza commented Mar 1, 2021

oops could you merge/rebase @schamberg97 to trigger CI ?

@schamberg97
Copy link
Contributor Author

oops could you merge/rebase @schamberg97 to trigger CI ?

Tried, to no avail

@waghanza
Copy link
Collaborator

waghanza commented Mar 2, 2021

could you redo this ? normally you should be able to now ...

@schamberg97
Copy link
Contributor Author

@waghanza seems like it’s finally running :)

@waghanza waghanza enabled auto-merge (squash) March 2, 2021 10:26
@schamberg97
Copy link
Contributor Author

@waghanza surprisingly, the CI shows mixed results - the uWebSockets variant has no problem, while the regular, only native node.js variant has issues. Probably a flake

@waghanza
Copy link
Collaborator

waghanza commented Mar 2, 2021

@schamberg97 npm try to install uWebSocket for the default
in my package-lock.json

"uWebSockets.js": {
      "version": "git+ssh://git@github.com/uNetworking/uWebSockets.js.git#3dbec7b56d627193e20705844b6bd10e49848b8c",
      "from": "uWebSockets.js@github:uNetworking/uWebSockets.js#v18.4.0"
    },

2 solutions :

  • add git to build_deps
  • does not require uWebSocket if mode is default

I find the second solution, more elegant, and liter (no need to install an unused package)

@waghanza waghanza disabled auto-merge March 8, 2021 16:58
@waghanza waghanza merged commit 55a16ac into the-benchmarker:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants