-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Javascript] Fyrejet update to 3.0 #4017
Conversation
Awesome. You can also test the new features #3958, I mean this feature allow one framework to be test with multiple runtimes ( |
oops could you merge/rebase @schamberg97 to trigger CI ? |
Tried, to no avail |
could you redo this ? normally you should be able to now ... |
@waghanza seems like it’s finally running :) |
@waghanza surprisingly, the CI shows mixed results - the uWebSockets variant has no problem, while the regular, only native node.js variant has issues. Probably a flake |
@schamberg97 "uWebSockets.js": {
"version": "git+ssh://git@github.com/uNetworking/uWebSockets.js.git#3dbec7b56d627193e20705844b6bd10e49848b8c",
"from": "uWebSockets.js@github:uNetworking/uWebSockets.js#v18.4.0"
}, 2 solutions :
I find the second solution, more elegant, and liter (no need to install an unused package) |
New fyrejet major version.
One of the modes in the framework is removed. uWebSockets version is still provided, hopefully it is not going to create problems this time around.