Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Laravel + Servel #4041

Merged
merged 1 commit into from
Mar 21, 2021
Merged

Add Laravel + Servel #4041

merged 1 commit into from
Mar 21, 2021

Conversation

gregorip02
Copy link

No description provided.

@gregorip02 gregorip02 requested a review from waghanza as a code owner March 6, 2021 20:34
@waghanza
Copy link
Collaborator

waghanza commented Mar 7, 2021

Thanks for your awesome contribution ❤️

If I may, servel is not a framework, but an adapter for workerman. As such, I think having it here is not accurate.

However, I can use it for #3958, this will allow laravel to be use either with php/fmp or with workerman (we have also swoole coming).

Do you agree ?

@gregorip02
Copy link
Author

Sure, I agree with you, I'll be watching when this project can test variants (:

@waghanza
Copy link
Collaborator

waghanza commented Mar 7, 2021

I can do the PR :-) and will will cc you

@waghanza waghanza marked this pull request as draft March 9, 2021 09:12
@waghanza waghanza changed the base branch from master to php/variants/laravel March 21, 2021 08:30
@waghanza waghanza marked this pull request as ready for review March 21, 2021 08:31
@waghanza waghanza merged commit 6943231 into the-benchmarker:php/variants/laravel Mar 21, 2021
waghanza pushed a commit that referenced this pull request Mar 21, 2021
@gregorip02 @waghanza
[PHP] Add swoole support for laravel (#4041)
92a51b9
waghanza pushed a commit to waghanza/web-frameworks that referenced this pull request Mar 24, 2021
@gregorip02 @waghanza
[PHP] Add swoole support for laravel (the-benchmarker#4041)
5799c25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waghanza waghanza waghanza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregorip02 @waghanza