Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release - 04112024 #7925

Merged
merged 2 commits into from
Nov 4, 2024
Merged

New release - 04112024 #7925

merged 2 commits into from
Nov 4, 2024

Conversation

waghanza
Copy link
Collaborator

@waghanza waghanza commented Nov 3, 2024

Failing frameworks
  • act
  • chubbyts-uwebsockets
  • low-http-server
  • oak-bun
  • oak-deno
  • spliffy
  • turbo

@donywan for bun, I have

bun run root@4264daf7dd61:/usr/src/app# bun app.ts
error: Cannot find module '@oak/oak' from '/usr/src/app/app.ts'

Bun v1.1.34 (Linux arm64)

for deno

root@e03514a217e3:/usr/src/app# deno run app.ts
error: Could not resolve "@oak/oak", but found it in a package.json. Deno expects the node_modules/ directory to be up to date. Did you forget to run `deno install`?
    at file:///usr/src/app/app.ts:1:37
root@e03514a217e3:/usr/src/app# deno install
error: npm package '@jsr/oak__oak' does not exist.
root@e03514a217e3:/usr/src/app#

@waghanza waghanza added the release This PR contains results update label Nov 3, 2024
@donywan
Copy link
Contributor

donywan commented Nov 4, 2024

I used jsr. https://jsr.io/@oak/oak

@waghanza
Copy link
Collaborator Author

waghanza commented Nov 4, 2024

Yes, seems to work locally, but not inside the container @donywan

When login onto the container, and trying deno run app.ts, I have

error: Could not resolve "@oak/oak", but found it in a package.json. Deno expects the node_modules/ directory to be up to date. Did you forget to run `deno install`?
    at file:///usr/src/app/app.ts:1:37

and deno install leads to

error: npm package '@jsr/oak__oak' does not exist.

@donywan
Copy link
Contributor

donywan commented Nov 4, 2024

Yes, seems to work locally, but not inside the container @donywan

When login onto the container, and trying deno run app.ts, I have

error: Could not resolve "@oak/oak", but found it in a package.json. Deno expects the node_modules/ directory to be up to date. Did you forget to run `deno install`?
    at file:///usr/src/app/app.ts:1:37

and deno install leads to

error: npm package '@jsr/oak__oak' does not exist.

Try deleting the oak dependency in package.json.

@donywan
Copy link
Contributor

donywan commented Nov 4, 2024

@waghanza deno.json

{
  "imports": {
    "@oak/oak": "jsr:@oak/oak@^17.1.3"
  }
}

@waghanza
Copy link
Collaborator Author

waghanza commented Nov 4, 2024

Needs a package.json and a deno.json ?

@donywan
Copy link
Contributor

donywan commented Nov 4, 2024

Needs a package.json and a deno.json ?

Needs deno.json.
The latest version of oak in the current npm repository is 14.1.0. https://www.npmjs.com/package/@oakserver/oak.So you need to use jsr to install dependencies.

@waghanza waghanza merged commit 2d28595 into master Nov 4, 2024
246 of 257 checks passed
@waghanza waghanza deleted the update branch November 4, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release This PR contains results update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants