Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tagging recordings #10

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

honicole
Copy link

Hello,

I am submitting a PR to support a wrapper for tagging Hotjar recordings so my team can use this in a project.

hj('tagRecording', ['tag1', 'tag2']);

I am unfamiliar with contributing to open-source projects so please let me know if I am missing anything.
Thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@olavoparno
Copy link
Member

@honicole thank you very much for your contribution, it really gladens me knowing this tool is of help. Thanks for the grammar fixes too haha

@all-contributors please add @honicole for code, ideas, doc

@allcontributors
Copy link
Contributor

@olavoparno

I've put up a pull request to add @honicole! 🎉

@olavoparno olavoparno merged commit 9541e06 into the-bugging:main Jul 19, 2021
@olavoparno
Copy link
Member

I'll reply here once the new version is up and running. We still have to add it to actions.

@olavoparno
Copy link
Member

Please do check for version 1.2.0 and report back if everything is ok @honicole

Again, thank you.

https://www.npmjs.com/package/react-use-hotjar/v/1.2.0

@honicole
Copy link
Author

@olavoparno Hi, it is working great, thanks!

@honicole honicole deleted the supoort-tagging-recordings branch July 23, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants