Memoize Authorization.access #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Authorization.access is called at least once for every entity returned in a request, it is a very hot path. Computing scope intersections is a reasonably expensive operation, and the async nature of the backing entities (grant, user, roles) makes this method relatively slow even when those are memoized and db calls can be avoided. An executor is already the context used for memoization of database calls, and this expands that to include memoization of calls to `Authorization.access`.
|
In local tests, this provides up to a 7x performance improvement when returning long lists not already filtered for access using SQL. Switching relational lists to use SQL would likely yield another ~1.5x performance improvement, but requires significant additional effort. Paginated lists obviously stand to gain even more from translation to SQL, and this continues to be tracked by #220. |
ebrown32
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Authorization.access is called at least once for every entity returned in a request, it is a very hot path. Computing scope intersections is a reasonably expensive operation, and the async nature of the backing entities (grant, user, roles) makes this method relatively slow even when those are memoized and db calls can be avoided.
An executor is already the context used for memoization of database calls, and this expands that to include memoization of calls to
Authorization.access.