-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added v12_10 xsd files #3
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid to me! I do want to note that this needs to be a major release since we're changing the default, and that's fine with me.
What do you think about matching their versions? So going straight to 12.10. |
I have mixed feelings about that as a general strategy. Semver is super useful when describing changes to a single interface, but much less suited for situations with complex interdependencies. For example, moving from their API v11 to v12 might change our API in a backwards-incompatible way, which is great: bump from v11.x.x to v12.0.0. However, if we then realize the need to make a breaking change in our API, we would have to either break the version coordination and release v13.0.0 that still corresponds to their v12 API, or wait until they release v13 so we can introduce our breaking change. All that said, I don't expect a lot of changes here, so I'd be OK trying to keep them coordinated – it's certainly much easier to follow whey coordination is possible. |
Interesting point. I hadn't thought about that case. If we're not going to do that then it might make sense to also not change the default version as a general strategy. It might even make sense to push a new major this time where we make version a required config param with no default. A default hardly makes sense anyways since there are many valid versions of the API. |
Quality Gate failedFailed conditions |
No description provided.