Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added v12_10 xsd files #3

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

added v12_10 xsd files #3

wants to merge 9 commits into from

Conversation

nickcarenza
Copy link
Contributor

No description provided.

Copy link
Member

@mike-marcacci mike-marcacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me! I do want to note that this needs to be a major release since we're changing the default, and that's fine with me.

@nickcarenza
Copy link
Contributor Author

What do you think about matching their versions? So going straight to 12.10.

@mike-marcacci
Copy link
Member

I have mixed feelings about that as a general strategy. Semver is super useful when describing changes to a single interface, but much less suited for situations with complex interdependencies.

For example, moving from their API v11 to v12 might change our API in a backwards-incompatible way, which is great: bump from v11.x.x to v12.0.0. However, if we then realize the need to make a breaking change in our API, we would have to either break the version coordination and release v13.0.0 that still corresponds to their v12 API, or wait until they release v13 so we can introduce our breaking change.

All that said, I don't expect a lot of changes here, so I'd be OK trying to keep them coordinated – it's certainly much easier to follow whey coordination is possible.

@nickcarenza
Copy link
Contributor Author

Interesting point. I hadn't thought about that case. If we're not going to do that then it might make sense to also not change the default version as a general strategy. It might even make sense to push a new major this time where we make version a required config param with no default. A default hardly makes sense anyways since there are many valid versions of the API.

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14 Security Hotspots
30.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants