Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement (docker): Add more archs #1321

Conversation

leojonathanoh
Copy link

@leojonathanoh leojonathanoh commented Nov 22, 2023

The build succeeded, see leojonathanoh#2.

docker pull ghcr.io/leojonathanoh/snappymail:pr-2-0d9c2a8
docker pull leojonathanoh/snappymail:pr-2-0d9c2a8

@the-djmaze the-djmaze added the enhancement New feature or request label Nov 22, 2023
@the-djmaze
Copy link
Owner

the-djmaze commented Nov 22, 2023

Should we really add ARMv6 and ARMv7?
Besides that they are old... They are 32bit and that can have conflicts, because IMAP uses 64bit numbers (don't work in PHP 32bit).

@leojonathanoh
Copy link
Author

Agreed. They are taking super long to build, over an hour. So, only arm64?

@leojonathanoh leojonathanoh force-pushed the enhancement/docker-add-linux-arm64-arch-pr branch from bb0d349 to c4b0b78 Compare November 22, 2023 22:35
@leojonathanoh
Copy link
Author

worth adding linux/s390x?

@the-djmaze
Copy link
Owner

worth adding linux/s390x?

When people start using 64bit mainframes and docker. They will also probably ask to support MAILBOX-REFERRALS (RFC 2193, 5258) 😆
As:

A001 DELETE "SHARED/FOO"
A001 NO [REFERRAL IMAP://user;AUTH=*@SERVER2/SHARED/FOO] Remote mailbox. Try SERVER2.

@leojonathanoh
Copy link
Author

don't really know what that means 😕 you mean that's only supported on 390x?

@leojonathanoh leojonathanoh changed the title Enhancement (docker): Add linux/arm64 arch Enhancement (docker): Add more archs Nov 22, 2023
@leojonathanoh leojonathanoh force-pushed the enhancement/docker-add-linux-arm64-arch-pr branch from 0ab08f3 to 4f45a72 Compare November 22, 2023 23:43
@the-djmaze
Copy link
Owner

don't really know what that means 😕

IMAP can be setup to have "remote" mailboxes.
Say your enterprise server/mainframe is full/overloaded and you moved half of the mailboxes to a different server.
Then IMAP can tell the client (SnappyMail) that some are \Remote and then we need RLIST or RLSUB commands to list them or the LIST-EXTENDED REMOTE.

With 390x i think we are more in the boat to implement this IMAP feature then with normal docker instances.

@leojonathanoh
Copy link
Author

i see, shouldn't this be a IMAP protocol specific implementation? for it to be specific to an arch is strange.

@the-djmaze
Copy link
Owner

It is IMAP protocol specific. But i wonder if we should support 390x

@leojonathanoh
Copy link
Author

yeah. but so long as the builds / tests succeed, it is assumed that 390x should work just as any arch would. It's not very used much in the wild anyway 🥲

@leojonathanoh
Copy link
Author

guess we could drop it? your take i guess 😄

@the-djmaze
Copy link
Owner

It's not very used much in the wild anyway 🥲

Then skip it. Arm64 will be enough then.
Pretty useless to wait longer for archs that are hardly used.

@leojonathanoh leojonathanoh force-pushed the enhancement/docker-add-linux-arm64-arch-pr branch from 4f45a72 to 5265883 Compare November 23, 2023 00:00
@the-djmaze
Copy link
Owner

I will keep in mind to drop linux/386 within a few years as well.

#830

@the-djmaze
Copy link
Owner

Error: Input does not meet YAML 1.2 "Core Schema" specification: push
Support boolean input list: `true | True | TRUE | false | False | FALSE`

@leojonathanoh
Copy link
Author

Let me rebase

@leojonathanoh leojonathanoh force-pushed the enhancement/docker-add-linux-arm64-arch-pr branch from 5265883 to 33558bf Compare November 23, 2023 00:07
@leojonathanoh
Copy link
Author

where are you seeing the yaml error?

@the-djmaze
Copy link
Owner

at docker build

@leojonathanoh
Copy link
Author

see it, second

@leojonathanoh leojonathanoh force-pushed the enhancement/docker-add-linux-arm64-arch-pr branch from 7c205ad to 7f6833f Compare November 23, 2023 00:16
@leojonathanoh
Copy link
Author

39 mins for cacheless builds, guess that's fine? but there's docker caching in the CI, so if it hits the cache, it will be much faster. Which, should be most of the time.

@the-djmaze the-djmaze merged commit ee99590 into the-djmaze:master Nov 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants