Amend listener for RSVP date start/end

[dpanta94]

Continuing work of PRs:

1. Feat/ticket actions #3532
2. Ticket stock listener will send pre and post update values #3551

I noticed that the RSVP would not create start/end actions during its initial creation. That was because for our code, the WP_Post that would was created it was not yet a Ticket_Object.

So i am sending every request to sync RSVP dates to be performed during the request's end.

The conditionals being removed are already happening in sync_ticket_dates_actions - so the only thing that is affected by said change is that more IDs would be eligible for date sync during the request's end. But they will be correctly be filtered based on if they are Tickets or not.

Why wasn't that caught by tests?

The reason is simple: order of meta keys is different for tests vs production.

see in tests:

event-tickets/tests/_support/Commerce/RSVP/Ticket_Maker.php

Line 46 in 4fbfb79

'_tribe_rsvp_for_event' => $post_id,

_tribe_rsvp_for_event key comes before start/end dates, while in production comes later.

As a result our load_ticket_object method would fail here because an event would not be found for the ticket in production, but in tests would!

[Camwyn]

Trait needs a docblock.

[Camwyn]

Trait needs a docblock.

No, that's in tests, nvm