Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Sticky toolbar does not stick #69

Closed
nickvelloff opened this issue Feb 18, 2016 · 16 comments
Closed

iOS - Sticky toolbar does not stick #69

nickvelloff opened this issue Feb 18, 2016 · 16 comments

Comments

@nickvelloff
Copy link
Contributor

screenshot 2016-02-17 21 11 27

@nickvelloff
Copy link
Contributor Author

There are 2 different issues shown in this video.

  1. When not editing (no keyboard) the toolbar disappears and re-appears
  2. When editing the toolbar scrolls up and does not re-appear
    ed-bug

@nickvelloff
Copy link
Contributor Author

@forresto this fix is definitely MVP for v1.

@nickvelloff
Copy link
Contributor Author

@hannesstruss does this happen on Android?

@hannesstruss
Copy link

No, not that intensely – the toolbar jumps a tiny bit when I start scrolling down from the very top though: editor-toolbar-jump.mov

@forresto
Copy link
Contributor

Looks like it it is stuck, but behind the black header? Could adding some body padding-top to your version of the html help?

@nickvelloff
Copy link
Contributor Author

I believe it actually disappears but I'll make header transparent to test.

@nickvelloff
Copy link
Contributor Author

So the toolbar visibility is actually toggled, so I don't think padding would have an effect.

@nickvelloff
Copy link
Contributor Author

FWIW the web view itself is constrained such that the webview.top = header.bottom

@nickvelloff
Copy link
Contributor Author

Logged issue upstream ProseMirror/prosemirror#223

@nickvelloff
Copy link
Contributor Author

@forresto feel free to close unless you want to track here

@forresto
Copy link
Contributor

Let me try making it more sticky first.

@nickvelloff
Copy link
Contributor Author

👍 If we can do it without it turning into a huge time suck for you it would be 👯

@forresto
Copy link
Contributor

Is absolute broken in the same way as fixed? Could hack it with that on scroll.

@forresto
Copy link
Contributor

Will try.

@nickvelloff
Copy link
Contributor Author

👌🏻 let me know if I can help try anything

forresto added a commit that referenced this issue Feb 26, 2016
forresto added a commit that referenced this issue Feb 27, 2016
@nickvelloff
Copy link
Contributor Author

It's certainly better. Usable at least.
ed-bug-lose-heading-fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants