add boolean: false for no-implicit-coercion because in TypeScript…

… `!!` is preferable (#149)
the-guild-org · Jan 9, 2023 · 10a328a · 10a328a
1 parent b85d396
commit 10a328a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/wise-rocks-punch.md b/.changeset/wise-rocks-punch.md
@@ -0,0 +1,5 @@
+---
+'@theguild/eslint-config': patch
+---
+
+add `boolean: false` for `no-implicit-coercion` because in TypeScript `!!` is preferable
diff --git a/packages/eslint-config/src/base.js b/packages/eslint-config/src/base.js
@@ -129,7 +129,14 @@ module.exports = {
     'import/first': 'error',
     // Disallow shorthand type conversions
     // https://eslint.org/docs/latest/rules/no-implicit-coercion
-    'no-implicit-coercion': ['error', { disallowTemplateShorthand: true }],
+    'no-implicit-coercion': [
+      'error',
+      {
+        disallowTemplateShorthand: true,
+        // in TypeScript `!!` is preferable https://www.typescriptlang.org/docs/handbook/2/narrowing.html#truthiness-narrowing
+        boolean: false,
+      },
+    ],
     // Disallow specified modules when loaded by `import` declarations
     // https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/no-restricted-import.md
     'n/no-restricted-import': ['error', RESTRICTED_MODULES],