Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors #236

Merged
merged 21 commits into from
Sep 10, 2022
Merged

Contributors #236

merged 21 commits into from
Sep 10, 2022

Conversation

GrantBirki
Copy link
Member

Contributors 💻

This pull request uses GitHub's Primer React components to render GitHub like Avatars for contributors who have helped the-hideout by contributing ❤️

Examples 📸

Footer Section

image

About Page

image


Bonus! You can pass in stack={true} to the component to get a stacked set of Avatars that expands on hover

<Contributors stack={true}/>

image

@GrantBirki GrantBirki added enhancement New feature or request UI UI updates related to HTML/CSS/JS labels Sep 8, 2022
@GrantBirki GrantBirki requested a review from a team as a code owner September 8, 2022 03:42
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

@GrantBirki
Copy link
Member Author

npm run test fails for me locally and in CI on this PR and I'm completely lost as to why.. 😱

@Shebuka
Copy link
Contributor

Shebuka commented Sep 8, 2022

npm run test fails for me locally and in CI on this PR and I'm completely lost as to why.. 😱

From the error seems that @github/combobox-nav (a dependency of @primer/react) uses some specific syntax that our Jest or Babel are not configured to recognize. I also don't know what to do about it... 🤷‍♂️

@GrantBirki
Copy link
Member Author

.deploy

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Deployment Triggered

GrantBirki, started a branch deployment 🚀

  • Branch: contributors
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production September 9, 2022 03:37 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: contributors

Successfully deployed branch contributors

Actor: GrantBirki, Action: issue_comment, Workflow: branch-deploy

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 9, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7fabcde
Status: ✅  Deploy successful!
Preview URL: https://f3ee97d8.tarkov-dev.pages.dev

View logs

@Shebuka
Copy link
Contributor

Shebuka commented Sep 9, 2022

Out of curiosity, why ignoring tippy? Wan't it passing ci correctly before?

@GrantBirki
Copy link
Member Author

When I added the Primer components our test started failing so I needed to exclude a few things. I'm honestly not sure why but I found github/combobox-nav#63 which pointing me in the direction of a coworker who suggested that change which fixed our CI 😄

@Shebuka
Copy link
Contributor

Shebuka commented Sep 9, 2022

I do understand that excluding primer solves the ci issue, I just don't understand why tippy is there too 😅 ci shenanigans? 🤣

@GrantBirki
Copy link
Member Author

shenanigans

Yes indeed. I have no idea either but it works 🤷

@Razzmatazzz
Copy link
Member

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered

Razzmatazzz, started a branch deployment 🚀

  • Branch: contributors
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production September 10, 2022 14:16 Inactive
@github-actions
Copy link
Contributor

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: contributors

Successfully deployed branch contributors

Actor: Razzmatazzz, Action: issue_comment, Workflow: branch-deploy

@Razzmatazzz Razzmatazzz merged commit 6970913 into main Sep 10, 2022
@Razzmatazzz Razzmatazzz deleted the contributors branch September 10, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI UI updates related to HTML/CSS/JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants