-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributors #236
Contributors #236
Conversation
👋 Thanks for opening a pull request!If you are new, please check out the trimmed down summary of our deployment process below:
|
|
From the error seems that @github/combobox-nav (a dependency of @primer/react) uses some specific syntax that our Jest or Babel are not configured to recognize. I also don't know what to do about it... 🤷♂️ |
.deploy |
Deployment TriggeredGrantBirki, started a branch deployment 🚀
You can watch the progress here 🔗 |
Deployment Results
Successfully deployed branch contributors
|
Deploying with
|
Latest commit: |
7fabcde
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f3ee97d8.tarkov-dev.pages.dev |
Out of curiosity, why ignoring |
When I added the Primer components our test started failing so I needed to exclude a few things. I'm honestly not sure why but I found github/combobox-nav#63 which pointing me in the direction of a coworker who suggested that change which fixed our CI 😄 |
I do understand that excluding |
Yes indeed. I have no idea either but it works 🤷 |
.deploy |
Deployment TriggeredRazzmatazzz, started a branch deployment 🚀
You can watch the progress here 🔗 |
Deployment Results
Successfully deployed branch contributors
|
Contributors 💻
This pull request uses GitHub's Primer React components to render GitHub like Avatars for contributors who have helped
the-hideout
by contributing ❤️Examples 📸
Footer Section
About Page
Bonus! You can pass in
stack={true}
to the component to get a stacked set of Avatars that expands on hover