fix(puppeteer): Default allow 3rd party cookies #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the latest update from Google/Chrome on deprecating 3rd Party cookies and trackers, chromium now by default enable the
block 3rd party cookiefeature, which result in inaccurate result from blacklight-collector as the 3rd party cookies are blocked by chromium and not visible to the outcome of the script.Why are we doing this? How does it help us?
Adding the
'--disable-features=TrackingProtection3pcd'as default arg to chromium so that 3rd-party cookie blocking is disabled by default. This will prevent blacklight-collector from giving people the illusion of certain site does not have 3rd party cookies because they did not show up in the outcome.How/where should this be tested?
What are potential areas for future improvement? Are there any dependencies (especially on 3rd party code)?
N/A
What are the relevant tickets, tasks, or documents?
https://developers.google.com/privacy-sandbox/cookies/prepare/test-for-breakage#:~:text=%2D%2Ddisable%2Dfeatures%3DTrackingProtection3pcd
Have you done the following, if applicable:
(optional: add explanation between parentheses)
TODOs / next steps: