This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
Install psycopg2 in the Docker container #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipenv install psycopg2
|
UP? |
|
This looks fine to me, but as this updates a bunch of other packages, I don't want to merge it straight-away. I'm going to leave this open for a little bit in the hopes that a few others chime in with a "it works for me". Our tests pass, but as our tests are currently few, I don't think they're enough to 👍 a PR like this. |
|
Or I can clean it you prefer :-) |
|
Thanks to your work in #489, this PR isn't necessary any more. Thanks again :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just run
pipenv install psycopg2I see that all the packages will be updated, is it acceptable?