Proposal to deploy Docker image on each commit on master

[sbrunner]

No description provided.

[stgarf]

@sbrunner It might make sense to push a docker image to DockerHub only on tagged releases to ensure we're only pushing quality containers based on tagged releases... (instead of each commit to master which may or may not contain a variety of in-progress work and bugs).

[sbrunner]

@stgarf Yes, I will work on that :-)

[ahyear]

is it possible, with a parametre in docker-compose.env (for exemple) to let the user choose between last tag and master?

[sbrunner]

@stgarf I change it and also test it as most as possible without a real password ...

[sbrunner]

@ahyear
It's not possible to do that in the docker-compose.env because he contains only environment variable for the container, to do that we should create a .env file.
And finally for me it should be done in another pull request...

[stgarf]

@ahyear

is it possible, with a parametre in docker-compose.env (for exemple) to let the user choose between last tag and master?

To do what you're asking you'd instead replace the build: ./ here and here with something à la image: <docker-image-you/want-to-run>:<tag-you-want> in your docker-compose.yaml.

[sbrunner]

What can be the next for this pull request?

[MasterofJOKers]

If we merge this, the deploy step will not be active, right? I assume it's not, because it should fail without a password and travis shows no failure for this PR.

So after merging this, someone™ would have to change the username, encrypt and set the password and activate the deploy step. Who would do that and how do you activate that step?

[sbrunner]

@MasterofJOKers You just needs to fill the DOCKER_USERNAME and DOCKER_PASSWORD, it don't failed because only tags and the master branch is published...

[MasterofJOKers]

@MasterofJOKers You just needs to fill the DOCKER_USERNAME and DOCKER_PASSWORD, it don't failed because only tags and the master branch is published...

Ah. So it will only fail for master, once we merge it, but since PRs aren't included, travis would still be green for them. I feared, we would end up not being able to merge anything afterwards.

Still, whoever has the appropriate rights on their account to allow pushing into docker should merge this PR, because she/he would have to create a commit right afterwards.

[sbrunner]

Thanks @MasterofJOKers for your review, I just the required changes :-), Your right it's better ton don't break the master :-)

[sbrunner]

UP ...

[sbrunner]

Thanks for the approved But how can we merge in configure the Docker deployment?

[sbrunner]

Thanks @ahyear :-)

[danielquinn]

There's a discussion about this (and the future of how we handle Docker integration) going on here.