Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#7 #19

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Issue#7 #19

merged 2 commits into from
Oct 27, 2020

Conversation

jossiey
Copy link
Contributor

@jossiey jossiey commented Oct 27, 2020 •
edited by the-pat
Loading

My updates include:

  1. var -> const and let.
  2. using string interpolation string ${"concatenation"} to replace "string" + "concatenation"
  3. extract function getGreatPumpkin() and function getSpookyFriend(top, left, url)

Closes #7

@the-pat the-pat self-requested a review October 27, 2020 09:57
the-pat
the-pat approved these changes Oct 27, 2020
View reviewed changes
Copy link
Owner

@the-pat the-pat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Happy hacking 🎃

@the-pat the-pat merged commit 039feb8 into the-pat:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-pat the-pat the-pat approved these changes

Assignees

@jossiey jossiey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor and Modernize
2 participants
@jossiey @the-pat