Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for changing the data record duration #14

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

marcoross
Copy link
Contributor

No description provided.

@marcoross marcoross self-assigned this Dec 5, 2023
@marcoross marcoross marked this pull request as draft December 5, 2023 09:39
@marcoross marcoross marked this pull request as ready for review December 5, 2023 09:46
Copy link
Contributor

@hofaflo hofaflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to rewrite annotation signals to keep them valid. Optimally, this would be done separately for each annotation signal, but if that is too cumbersome it is probably fine to merge multiple annotation signals into one.

Note: I added 2 commits fixing docstring issues.

edfio/edf.py Outdated Show resolved Hide resolved
edfio/edf.py Show resolved Hide resolved
edfio/edf.py Outdated Show resolved Hide resolved
tests/test_edf.py Show resolved Hide resolved
tests/test_edf.py Outdated Show resolved Hide resolved
edfio/edf.py Show resolved Hide resolved
edfio/edf.py Show resolved Hide resolved
edfio/edf.py Outdated Show resolved Hide resolved
Copy link
Contributor

@hofaflo hofaflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and thorough testing!

edfio/edf.py Outdated Show resolved Hide resolved
edfio/edf.py Outdated Show resolved Hide resolved
edfio/edf.py Outdated Show resolved Hide resolved
tests/test_edf.py Outdated Show resolved Hide resolved
edfio/edf.py Outdated Show resolved Hide resolved
…` fixture, refactor some inefficient code.
@hofaflo hofaflo changed the title Change record duration Add method for changing the data record duration Dec 6, 2023
@hofaflo hofaflo merged commit 2a547b8 into main Dec 6, 2023
4 checks passed
@hofaflo hofaflo deleted the change-record-duration branch December 6, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants