Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention behind the current implementation of header fields in the
Edf
andEdfSignal
classes, based onRawHeaderField
s, was to avoid bugs caused by having to repeat the field length everywhere a header field is set. However, it comes with a few issues:#type: ignore
comments are needed to make mypy happy, because some non-public attributes are created viasetattr
EdfSignal.label
,Edf.startdate
,Edf.starttime
)I think these issues outweigh the initially desired benefit and would therefore like to replace the custom descriptors with ordinary properties.