Allow creating Edf containing only annotations #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoross
approved these changes
Nov 28, 2023
Comment on lines
+1018
to
+1021
| def test_signals_cannot_be_set_to_empty_sequence_for_edf_without_annotations(): | ||
| edf = Edf([EdfSignal(np.arange(2), 1)]) | ||
| with pytest.raises(ValueError, match="signals must not be empty"): | ||
| edf.signals = [] |
There was a problem hiding this comment.
I tried adding the positive test case, where I'd try to set the signals to an empty sequence for an Edf object that does have annotations. However, this failed too, which made me think about the behavior of the signals property in the context of an annotations signal being present:
The current behavior is that the annotations signal is generated when adding annotations and the signals property returns a tuple including that annotations channel. Now, what happens if we set the signals property with a non-empty sequence of signals that does not contain the already existing annotations signal? Will the annotations be deleted? I think the behavior is okay for now, but we should discuss it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in section 2.1.2 of the EDF+ specs, an EDF+ may contain only an annotation signal and no ordinary signals, e.g. to store a hypnogram.