Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Frooastboard Walnut #1234

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Add support for Frooastboard Walnut #1234

merged 5 commits into from
Jul 27, 2022

Conversation

Frooastside
Copy link
Contributor

Description

I added the Frooastboard Walnut KB to via

QMK Pull Request

QMK PR

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Frooastside Frooastside changed the title Addition of Frooastboard Walnut to via Add support of Frooastboard Walnut Apr 17, 2022
@Frooastside Frooastside changed the title Add support of Frooastboard Walnut Add support for Frooastboard Walnut Apr 17, 2022
@wilba
Copy link
Contributor

wilba commented Jul 27, 2022

@Frooastside did you close this PR? I am making changes to support QMK RGB Matrix in VIA and this keyboard is in QMK master but no VIA definition was added. I don't know if this PR was closed by accident or not.

@wilba wilba reopened this Jul 27, 2022
@Frooastside
Copy link
Contributor Author

Frooastside commented Jul 27, 2022

@wilba I did not close it. But I noticed it too and was a little bit confused. If you want, it would be great if my pr could be merged.

@wilba wilba merged commit 48fe054 into the-via:master Jul 27, 2022
@Frooastside
Copy link
Contributor Author

Thank you very much @wilba 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants