Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organized versions of mikeneko65 #1252

Merged
merged 3 commits into from
Jul 25, 2022

Conversation

takishim
Copy link
Contributor

@takishim takishim commented May 2, 2022

Description

Organized versions of mikeneko65.

  • change v4 version to v1 version
  • delete v3 version

QMK Pull Request

qmk/qmk_firmware#16985

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

- change v4 version to v1 version
- delete v3 version
@takishim
Copy link
Contributor Author

takishim commented Jul 3, 2022

@wilba and other committers
I am sincerely sorry for the ping.
There is a defect in my json file for this keyboard I had already sold.
I am very sorry to impose this on you, but could you please review & merge this PR as soon as possible?

@takishim takishim mentioned this pull request Jul 3, 2022
6 tasks
@yiancar
Copy link
Collaborator

yiancar commented Jul 24, 2022

Hello as you can see there is a conflict.
Can you please fix it so then I can merge:)

Cheers,
Yiangos

@takishim
Copy link
Contributor Author

Hi, I resolved the conflict. Thanks.

@yiancar
Copy link
Collaborator

yiancar commented Jul 25, 2022

Cheers thanks!

@yiancar yiancar merged commit 2d29c0c into the-via:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants