Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json for Work Louder Micro macropad #1308

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

drashna
Copy link
Contributor

@drashna drashna commented Jul 7, 2022

Description

Add VIA support for the Work Louder Micro board.

QMK Pull Request

qmk/qmk_firmware#17586

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yiancar
Copy link
Collaborator

yiancar commented Jul 17, 2022

Hello! Sadly the keyboard is not already merged into QMK main.
This is incorrectly checked in the checklist. Please reopen the PR once that is done as we are trying to clean the PR list a bit:)

Cheers!

@yiancar yiancar closed this Jul 17, 2022
@drashna
Copy link
Contributor Author

drashna commented Jul 21, 2022

Note: "via support for this keycode..." is not actually checked. Intentionally.

Also, no way for me to reopen this without opening a new PR.

Also, why does #1303 get merged, when it's not been merged into QMK yet, and this gets closed?

@yiancar
Copy link
Collaborator

yiancar commented Jul 24, 2022

Yep a mistake happened there with 1303.
Let me know when your ready and I will reopen it for you!:)

@yiancar yiancar added the pending QMK merge Waiting for merge into QMK master label Jul 24, 2022
@drashna
Copy link
Contributor Author

drashna commented Jul 27, 2022

Let me know when your ready and I will reopen it for you!:)

QMK PR merged upstream :)

@yiancar yiancar reopened this Jul 27, 2022
@yiancar
Copy link
Collaborator

yiancar commented Jul 27, 2022

Cheers thanks!

@yiancar yiancar merged commit 01b8b98 into the-via:master Jul 27, 2022
@drashna drashna deleted the patch-1 branch July 27, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants