Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 11,2 position on mokulua/mirrored #1429

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

lesshonor
Copy link
Contributor

Description

"You couldn't have gotten your files crossed and submitted the wrong revision of the layout definition to the VIA repo, could you @lesshonor?"
...Turns out, much to my chagrin, yes.

QMK Pull Request

qmk/qmk_firmware#17125
qmk/qmk_firmware#17055

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22 Xelus22 merged commit b93ac6e into the-via:master Sep 19, 2022
@lesshonor lesshonor deleted the mokulua-fix branch September 21, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants