Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sunsetter R2 by Charue Designs #1733

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Add Sunsetter R2 by Charue Designs #1733

merged 3 commits into from
Feb 11, 2024

Conversation

leeandher
Copy link
Contributor

@leeandher leeandher commented Mar 7, 2023

This PR adds Sunsetter R2 definition. I had downloaded it from the Charue Design discord before it shut down, and I'm not sure if the designer will add the definition themselves.

I don't have the keyboard on me to test at the moment, but I'll work with a friend to get screenshots and verify it.

QMK Pull Request

qmk/qmk_firmware#17269

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@leeandher
Copy link
Contributor Author

Got the board from a friend, seemed to work as expected. Flashed with the firmware from https://www.caniusevia.com/docs/download_firmware and made sure I wasn't on V2 definitions.

@leeandher leeandher marked this pull request as ready for review February 9, 2024 02:59
@Xelus22 Xelus22 merged commit ea950ad into the-via:master Feb 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants