Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add erdnuss65 #1800

Merged
merged 5 commits into from
Apr 8, 2023
Merged

Add erdnuss65 #1800

merged 5 commits into from
Apr 8, 2023

Conversation

ctt-t
Copy link
Contributor

@ctt-t ctt-t commented Apr 2, 2023 •
edited
Loading

Description

Add erdnuss65

QMK Pull Request

QMK/qmk_firmware#20202

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove V2 definition (src folder one) as that is only for legacy support/boards

Xelus22
Xelus22 requested changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the spaces in file name. Replace with _, underscores please

@Xelus22 Xelus22 merged commit 0196974 into the-via:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctt-t @Xelus22