Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Bahrnob65 #1821

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Added Bahrnob65 #1821

merged 1 commit into from
Apr 22, 2023

Conversation

zykrah
Copy link
Contributor

@zykrah zykrah commented Apr 12, 2023 •
edited
Loading

Description

Added Bahrnob65 PCB

QMK Pull Request

qmk/qmk_firmware#20424

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@zykrah zykrah marked this pull request as draft April 12, 2023 07:39
@zykrah zykrah marked this pull request as ready for review April 16, 2023 10:02
@zykrah
Copy link
Contributor Author

zykrah commented Apr 16, 2023

Merged and ready for review.

@Xelus22 Xelus22 merged commit c7b05f0 into the-via:master Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zykrah @Xelus22